wip: new falco builder + consequent travis and regression tests refinements #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
dco-signoff: yes
size/L
dco-signoff: no
and removed
dco-signoff: yes
labels
leodido
changed the title
|
Ok, this is now blocked only from the
Notice that before there was no evidence of this because the |
poiana
added
release-note
kind/feature
release-note-none
and removed
release-note-none
release-note
labels
Closed
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
fntlnz
previously approved these changes
Jul 25, 2019
|
LGTM label has been added. Git tree hash: 7320cd997fba886a6b49a07454b328eef2307da5
|
|
The internal CI (jenkins) is failing because it seems to not pull the falcosecurity/falco-builder and falcosecurity/falco-tester (latest) images which I pushed to the the Falco docker hub account. You can see this in the logs. Log of the last build (notice the toolset-2 ..) Log of the previous (successful) build: |
mfdii
reviewed
Jul 25, 2019
… tester) Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
@mfdii There is only a sentence or two (about the default value of I'll submit that one tomorrow, but I do not think that it is blocking this one (as long checks turn all green, clearly). |
mstemm
approved these changes
Jul 25, 2019
|
LGTM label has been added. Git tree hash: ad9d3a4b1c64d73c4099a96304b5b7de3e704136
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstemm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leodido
added a commit
to falcosecurity/falco-website
that referenced
this pull request
Jul 26, 2019
Fixes #52 Refs falcosecurity/falco#719 changes Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
added a commit
to falcosecurity/falco-website
that referenced
this pull request
Jul 26, 2019
Fixes #52 Refs falcosecurity/falco#719 changes Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
This PR approaches the reorganization and improvement of the current build and CI systems.
To do so it modifies various existing pieces in order to improve the degree of their robustness.
Namely, this PR:
makes the TravisCI build faster (-5min)
enforces the
CMAKE_BUILD_TYPE(for CMake) andBUILD_TYPE(for docker images) variables to only accept "release" or "debug" values (case-insensitive)fixes
BUILD_TYPE=debugwhich was not respected until nowmakes CMake able to compute the
FALCO_VERSIONfrom the git indexFALCO_VERSIONvariable is now equal to:0.<commit hash>[.dirty](where "dirty" suffix indicates eventual changes detected by the git index).It always starts with a digit because it is intended to be provided to DEB/RPM/etc. packages too.
simplifies the TravisCI file moving cmake, package, tests, regression tests commands into separate file inside the
./hackdirectorymakes CMake always use curl avoiding wget
reorganizes the way (some) docker images are done (structure, entry points, build arguments, environment, etc.)
introduces a new falco-builder docker images which has Centos7 as base layer
makes the falco-builder image use the toolset 7 (gcc 7.3.1, cpluplus 2014) and Cmake 3.5
forces falco-builder to use
DNDEBUGto disable assertions while buildingBUILD_TYPE=debugchanges the base image of falco-tester docker image to be Fedora 28
provides
usagecommands for both the falco-builder and the falco-tester docker imagesmakes
FALCO_VERSIONmandatory has a build argument fro the falco docker image (./docker/localdirectory)bumps the minimum CMake version to 3.3.2
improves the scripts used by Jenkins pipeline (internal CI)
Which issue(s) this PR fixes:
Fixes #723
Fixes #660
Fixes #623
Special notes for your reviewer:
This PR currently changes the TravisCI (and Jenkins) setup to use thefalcosecurity/falco-builder:chore-travisandfalcosecurity/falco-tester:chore-travisdocker images.As soon this is green and approved I'll push these images to the latest tag and I'll switch back the setups to use the latest tags. DONE.
Does this PR introduce a user-facing change?:
However the summary of the developer facing changes is:
0.<commithash>[.dirty]).