fix(docker): fixed docker entrypoints for driver loading. #3168
Conversation
|
/milestone 0.38.0 |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/docker_entrypoints
branch
from
cf2a39b to
3933fcd
Compare
|
/hold |
| @@ -89,11 +86,6 @@ while test $# -gt 0; do | |||
| ;; | |||
| --http-insecure) | |||
| HTTP_INSECURE="true" | |||
| ;; | |||
| --source-only) | |||
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/docker_entrypoints
branch
from
613a7cb to
da52edb
Compare
| --print-env) | ||
| /usr/bin/falcoctl driver printenv | ||
| exit 0 | ||
| ;; | ||
| --*) | ||
| >&2 echo "Unknown option: $1" | ||
| >&2 echo "Unknown option: $opt" |
| print_usage | ||
| exit 1 | ||
| ;; | ||
| *) | ||
| >&2 echo "Unknown driver: $1" | ||
| >&2 echo "Unknown driver: $opt" |
|
Refs: #3165 |
| /usr/bin/falcoctl driver config --type $driver | ||
| else | ||
| # Needed because we need to configure Falco to start with correct driver | ||
| /usr/bin/falcoctl driver config --type modern_ebpf --type ebpf --type kmod |
There was a problem hiding this comment.
Is this the order in which drivers are loaded? I would say we normally prioritize modern_ebpf, kmod, ebpf instead, right?
There was a problem hiding this comment.
Yes this is the prio order; we decided to go with ebpf before kmod.
We can change it later btw! (i mean, before the release).
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: