fix(userspace/falco): solve live multi-source issues when loading more than two sources #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…ctors Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
/milestone 0.35.1 |
43 tasks
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
FedeDP
reviewed
Jun 22, 2023
|
LGTM label has been added. Git tree hash: 4dd4c90db6bffd6dfb6b9c8034520afb5b3b28b7
|
Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
incertum
approved these changes
Jun 22, 2023
|
|
||
| // in live mode, each inspector should have registered at most two event sources: | ||
| // the "syscall" on, loaded at default at index 0, and optionally another | ||
| // one defined by a plugin, at index 1 |
There was a problem hiding this comment.
Just a comment: oh max one plugin is a limitations we may wanna consider addressing one day if we plan to extend the plugins functionally beyond what is possible today :)
|
LGTM label has been added. Git tree hash: 435933d25521203025ebc58f260cbc7e4584baea
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This fixes #2652, which caused Falco to fail when loading more than two simultaneous event sources for live event captures. The flaw was on a wrongly-implemented safety check, that caused Falco to fail even on legit situations.
Which issue(s) this PR fixes:
Fixes #2652
Special notes for your reviewer:
Does this PR introduce a user-facing change?: