Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace): minor pre-release improvements #2236

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This adds a bunch of chores and minor changes to clean-up the code for the upcoming release. Goals are:

  • Make log messages more uniform and consistent in formatting
  • Minor performance improvement chores: passing string by reference, using unordered_set, etc...

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(userspace): minor pre-release improvements

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…lookups

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…re is opened

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce jasondellaluce force-pushed the update/chores-and-updates-release branch from 784b8f6 to 18110f3 Compare October 6, 2022 16:53
Andreagit97
Andreagit97 previously approved these changes Oct 6, 2022
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 6, 2022

LGTM label has been added.

Git tree hash: f9c7b5224d44b57695daa5702f29eba3ffbd53af

@Andreagit97 Andreagit97 force-pushed the update/chores-and-updates-release branch from 18110f3 to a5f3ebf Compare October 6, 2022 17:06
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@Andreagit97 Andreagit97 force-pushed the update/chores-and-updates-release branch from a5f3ebf to 9766c06 Compare October 6, 2022 17:07
@poiana poiana removed the lgtm label Oct 6, 2022
@poiana poiana requested a review from Andreagit97 October 6, 2022 17:07
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 6, 2022
@poiana
Copy link
Contributor

poiana commented Oct 6, 2022

LGTM label has been added.

Git tree hash: b371761ef330be41d92e2ab8df87dc0341975aed

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3c02b40 into master Oct 6, 2022
@poiana poiana deleted the update/chores-and-updates-release branch October 6, 2022 19:27
@jasondellaluce jasondellaluce added this to the 0.33.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants