Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): make tests run locally (take 2) #2089

Merged

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Jun 23, 2022

Signed-off-by: Luca Guerra luca@guerra.sh

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

In an attempt to make it easier for people to run tests locally I messed up the bash script which currently does not report failed tests correctly. This reverts the change and adds correct instructions to the README about how to run it. As it turns out, I was missing an option or badly specified it before.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@jasondellaluce
Copy link
Contributor

/ok-to-test

@jasondellaluce
Copy link
Contributor

Closing and reopening to trigger the CI

/close

@poiana poiana closed this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@jasondellaluce: Closed this PR.

In response to this:

Closing and reopening to trigger the CI

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/reopen

@poiana poiana reopened this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

LGTM label has been added.

Git tree hash: e0998712ff02b81aff59f6bc96b99fd4d03a193f

@jasondellaluce
Copy link
Contributor

/milestone 0.32.1

@poiana poiana added this to the 0.32.1 milestone Jun 23, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Jun 23, 2022

/close

Closing and reopening to trigger the CI

@poiana poiana closed this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@leogr: Closed this PR.

In response to this:

/close

Closing and reopening to trigger the CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jun 23, 2022

/reopen

@poiana poiana reopened this Jun 23, 2022
@poiana
Copy link
Contributor

poiana commented Jun 23, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit 5dce4d2 into falcosecurity:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants