Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove kaizhe from falco rule owner #2050

Merged
merged 1 commit into from
Jun 23, 2022
Merged

remove kaizhe from falco rule owner #2050

merged 1 commit into from
Jun 23, 2022

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jun 8, 2022 •
edited by FedeDP
Loading

Signed-off-by: Kaizhe Huang khuang@aurora.tech

What type of PR is this?

Decided to step down from the falco maintainer role but remain as a reviewer till the new Falco rule owner step up.

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
N/A

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Kaizhe Kaizhe requested a review from mstemm June 8, 2022 16:28
@poiana poiana requested review from fntlnz and leodido June 8, 2022 16:28
@poiana poiana added the approved label Jun 8, 2022
leogr
leogr reviewed Jun 9, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kaizhe

I'm sorry to see that 🥲 , though I respect your decision. We will definitely miss you ❤️

You have outstandingly served this project as a maintainer. You always did a great job reviewing PRs (you know, I usually asked your help to review rules changes).

So, I'd propose to add yourself under the emeritus_approvers section (see k8s documentation). You deserve that 🤗

Is that ok for you? If yes please update the PR.

@leogr
Copy link
Member

leogr commented Jun 9, 2022

PS
Could you also rebase this PR? We need that just to fix the CI issue. Thank you.

@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 9, 2022
@Kaizhe
remove kaizhe from falco rule owner
c446e0a 
Signed-off-by: Kaizhe Huang <khuang@aurora.tech>
@Kaizhe Kaizhe force-pushed the kaizhe-step-down-from-maintainer branch from 7623ce2 to c446e0a Compare June 18, 2022 03:25
jasondellaluce
jasondellaluce approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for all the help!

@poiana poiana added the lgtm label Jun 18, 2022
@poiana
Copy link
Contributor

poiana commented Jun 18, 2022

LGTM label has been added.

Git tree hash: cad13cbd3a10d84afeaa3e41c6aff08b5398dc43

@poiana
Copy link
Contributor

poiana commented Jun 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, Kaizhe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe
Copy link
Contributor Author

Kaizhe commented Jun 19, 2022

k8s documentation

@leogr thanks for the reminding. As my plan to to continue to review PR till the new owner step up. Then I will put myself under the emeritus_approvers key.

@Kaizhe Kaizhe requested a review from leogr June 19, 2022 05:28
@jasondellaluce
Copy link
Contributor

/remove-milestone 0.33.0

/milestone 0.32.1

@poiana poiana modified the milestones: 0.33.0, 0.32.1 Jun 20, 2022
@Kaizhe Kaizhe merged commit 8a1f43f into master Jun 23, 2022
@poiana poiana deleted the kaizhe-step-down-from-maintainer branch June 23, 2022 03:16
@Kaizhe Kaizhe restored the kaizhe-step-down-from-maintainer branch June 23, 2022 03:16
@Kaizhe Kaizhe deleted the kaizhe-step-down-from-maintainer branch June 23, 2022 03:16
leogr added a commit to falcosecurity/rules that referenced this pull request Dec 21, 2022
@leogr
docs: set up OWNERS
238788d 
- approvers from falcosecurity/falco@b71eb7e
- reviewers from falcosecurity/falco@b378c3a
- emeritus from falcosecurity/falco#2050
- Plus volunteers from/~https://github.com/falcosecurity/evolution/issues/229

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@leogr leogr leogr approved these changes

@mstemm mstemm Awaiting requested review from mstemm

@fntlnz fntlnz Awaiting requested review from fntlnz

@leodido leodido Awaiting requested review from leodido

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

Labels
approved dco-signoff: yes lgtm release-note-none size/XS
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaizhe @leogr @jasondellaluce @poiana