cleanup plugins rules files #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3707942ab52219e98f461 Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Plugins' rules files now lives in their repositories. See falcosecurity/plugins#98 Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
cleanup/plugins-rules-files
branch
from
4190f17 to
d6a5cc9
Compare
|
Hey @leogr, this is a great thing. I feel like plugin rulesets are better suite to be in the plugins repository and distributed separately, thanks for making the first step in this direction. Since I was the CI failing, I pushed an additional commit in this branch to fix-up the regression tests related to k8s audit! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mstemm
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area rules
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1994
Special notes for your reviewer:
Ruleset files were already moved to the plugins repository by falcosecurity/plugins#98
/milestone 0.32.0
Does this PR introduce a user-facing change?: