Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(userspace/falco): use new plugin caps API #1982

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 26, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Port the plugins loading logic to new logic; it needs updated libs with this PR in: falcosecurity/libs#274

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@jasondellaluce
Copy link
Contributor

/milestone 0.32.0

FedeDP added 2 commits April 28, 2022 15:16
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP changed the title wip: new(userspace/falco): use new plugin caps API new(userspace/falco): use new plugin caps API Apr 28, 2022
…cc3254

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@jasondellaluce jasondellaluce mentioned this pull request Apr 28, 2022
27 tasks
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 29, 2022
@poiana
Copy link
Contributor

poiana commented Apr 29, 2022

LGTM label has been added.

Git tree hash: e3d83266da3346f3142da5c5fdca4804e6c7d6a4

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 7aed3b6 into falcosecurity:master Apr 29, 2022
@poiana
Copy link
Contributor

poiana commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants