-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: components opt-in mechanism for packages #1979
Conversation
…t names Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
c470d4b
to
beda44a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Great fix Leo! 😍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR allows for selectively declaring which components should be included in packages, using CPACK_INSTALL_CMAKE_PROJECTS.
It fixes the issue involuntarily introduced by falcosecurity/libs#247. All libs targets are now installing their artifacts in the installation location, so those files were caught by
cpack
and included in Falco packages. However, Falco does not need all those libraries and headers, since those dependencies are already bundled into the Falco executable. The new opt-in mechanism introduced in the Falco building system allows overcoming this issue.All recent
publish/docker-dev
CI jobs were failing for that reason. For example, seehttps://app.circleci.com/pipelines/github/falcosecurity/falco/2433/workflows/2d4d55c9-5528-4a0c-8fee-5b4ff168c484/jobs/22412
Note that the .deb installation failed because the package was trying to reinstall openssl files.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Another small issue was present and has been fixed by this. The
LIBS_PACKAGE_NAME
is not propagated in Falco, so all files weren't installed under thefalcosecurity
folder.Although that's irrelevant for packages (because we are not including those files anymore), it still applies for
make install
./milestone 0.32.0
Does this PR introduce a user-facing change?: