Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule(Disallowed K8s User): exclude allowed eks users #1960

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

darryk10
Copy link
Contributor

EKS uses some users for its need which generate noise for this rule.
Reference: https://docs.aws.amazon.com/eks/latest/userguide/default-roles-users.html

Signed-off-by: darryk10 stefano.chierici@sysdig.com
Co-authored-by: Alberto Pellitteri alberto.pellitteri@sysdig.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
EKS uses some users for its need which generate noise for this rule. This PR add a specific list for eks users to whitelists event related to this users.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Disallowed K8s User): exclude allowed EKS users

Signed-off-by: darryk10 <stefano.chierici@sysdig.com>
Co-authored-by: Alberto Pellitteri <alberto.pellitteri@sysdig.com>
Signed-off-by: darryk10 <stefano.chierici@sysdig.com>
@poiana
Copy link
Contributor

poiana commented Mar 25, 2022

@MikeC-Sysdig: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/close

@poiana
Copy link
Contributor

poiana commented Mar 29, 2022

@jasondellaluce: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this Mar 29, 2022
@jasondellaluce
Copy link
Contributor

/reopen

@poiana poiana reopened this Mar 29, 2022
@poiana
Copy link
Contributor

poiana commented Mar 29, 2022

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/S label Mar 29, 2022
@darryk10
Copy link
Contributor Author

/assign @Kaizhe

@poiana poiana added the lgtm label Apr 1, 2022
@poiana
Copy link
Contributor

poiana commented Apr 1, 2022

LGTM label has been added.

Git tree hash: ac268bb302864d9a58d74957f5d6fe8f2541a0f3

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 1, 2022
@poiana poiana merged commit 36bd07d into falcosecurity:master Apr 1, 2022
@jasondellaluce
Copy link
Contributor

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants