-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule(Disallowed K8s User): exclude allowed eks users #1960
Conversation
Signed-off-by: darryk10 <stefano.chierici@sysdig.com> Co-authored-by: Alberto Pellitteri <alberto.pellitteri@sysdig.com>
Signed-off-by: darryk10 <stefano.chierici@sysdig.com>
@MikeC-Sysdig: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@jasondellaluce: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@jasondellaluce: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Kaizhe |
LGTM label has been added. Git tree hash: ac268bb302864d9a58d74957f5d6fe8f2541a0f3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.32.0 |
EKS uses some users for its need which generate noise for this rule.
Reference: https://docs.aws.amazon.com/eks/latest/userguide/default-roles-users.html
Signed-off-by: darryk10 stefano.chierici@sysdig.com
Co-authored-by: Alberto Pellitteri alberto.pellitteri@sysdig.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
EKS uses some users for its need which generate noise for this rule. This PR add a specific list for eks users to whitelists event related to this users.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: