-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate allowed ecr registry rule #1725
Conversation
Welcome @TomKeyte! It looks like this is your first PR to falcosecurity/falco 🎉 |
Signed-off-by: Tom Keyte <tom.keyte@onsecurity.co.uk>
/assign @mstemm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thank you :)
/approve
LGTM label has been added. Git tree hash: 1d7aa63c3a8201f56e510d353c5ca82c85bdb637
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, TomKeyte The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.30.0 |
Closing and reopening to trigger CircleCI. |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Kaizhe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Falco eyes 👀
LGTM!
What type of PR is this?
/kind cleanup
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Removes a duplicate ECR repo starts_with rule in the allowed_aws_ecr_registry_root_for_eks macro
Which issue(s) this PR fixes: