Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude image analyzer #1321

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Exclude image analyzer #1321

merged 2 commits into from
Jul 20, 2020

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jul 20, 2020 •
edited by leogr
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Reduce false positive.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro user_trusted_containers): add `sysdig/node-image-analyzer` and `sysdig/agent-slim`

@Kaizhe Kaizhe requested a review from mstemm July 20, 2020 18:16
@poiana poiana requested review from leodido and mfdii July 20, 2020 18:16
@poiana poiana added the size/XS label Jul 20, 2020
@Kaizhe Kaizhe removed the request for review from mfdii July 20, 2020 18:18
mstemm
mstemm previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@poiana poiana added the lgtm label Jul 20, 2020
@poiana
Copy link
Contributor

poiana commented Jul 20, 2020

LGTM label has been added.

Git tree hash: 26f235be6b8c18cb85634e8c722c3b9facee850d

fntlnz
fntlnz previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

leodido
leodido previously approved these changes Jul 20, 2020
View reviewed changes
@leodido
Copy link
Member

leodido commented Jul 20, 2020

Thanks @Kaizhe, LGTM!

This is blocked by the approval and merge of: #1313

@leodido leodido changed the title Kh exclude image analyzer Exclude image analyzer Jul 20, 2020
Kaizhe added 2 commits July 20, 2020 14:06
@Kaizhe
rule update (macro: user_trusted_containers): add sysdig/node-image-a…
d37e3e2 
…nalyzer to macro user_trusted_containers

Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe
add sysdig/agent-slim to the user_trusted_images macro
189afa9 
Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe Kaizhe dismissed stale reviews from leodido, fntlnz, and mstemm via 189afa9 July 20, 2020 21:07
@Kaizhe Kaizhe force-pushed the kh_exclude-image-analyzer branch from c2ba758 to 189afa9 Compare July 20, 2020 21:07
@Kaizhe Kaizhe requested review from leodido, mstemm and fntlnz July 20, 2020 21:07
@poiana poiana added the lgtm label Jul 20, 2020
@poiana
Copy link
Contributor

poiana commented Jul 20, 2020

LGTM label has been added.

Git tree hash: 7ff5b2c063be099572f72888ad0195764819c6ac

@poiana
Copy link
Contributor

poiana commented Jul 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a9b4e6c into master Jul 20, 2020
@poiana poiana deleted the kh_exclude-image-analyzer branch July 20, 2020 21:41
@leogr leogr added this to the 0.25.0 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

@leodido leodido leodido approved these changes

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leodido leodido

@fntlnz fntlnz

@mstemm mstemm

Labels
approved dco-signoff: yes lgtm release-note size/XS
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kaizhe @poiana @leodido @fntlnz @mstemm @leogr