Provide and parse FALCO_VERSION_PRERELEASE part #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
fntlnz
previously approved these changes
Mar 10, 2020
|
LGTM label has been added. Git tree hash: 06a0a1119c48f24392d4f0f787eba81096e797e3
|
|
/milestone 0.21.0 |
mstemm
previously approved these changes
Mar 10, 2020
|
/hold |
…a docker build argument Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
/hold cancel |
fntlnz
approved these changes
Mar 10, 2020
|
LGTM label has been added. Git tree hash: 14df8aeecb5be847e7bcfcb409f78109f60497ce
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
poiana
added
approved
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
/milestone 0.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
It makes the build generate the FALCO_VERSION_PRERELEASE variable, too.
It contains the count of the commits from the last tag on the master.
So versions, from now one will be something like
0.20.0-48+86e6fe3, where 48 is the number of commits from release0.20.0.This also affects the Falco gRPC Version API, which will also return this new part of the version.
Moreover, having the prerelease version part that will automatically increment as soon we merge a new PR into the master, will fix the ordering of versions we currently have when installing Falco with
aptoryumorrpm.Which issue(s) this PR fixes:
Fixes #1087
Special notes for your reviewer:
Does this PR introduce a user-facing change?: