Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(content): improve Alert Formatting and add suggested_output #1435

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 16, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/milestone falco-0.40.0
/hold for 0.40.0

@leogr leogr requested a review from FedeDP January 16, 2025 11:27
@leogr leogr linked an issue Jan 16, 2025 that may be closed by this pull request
5 tasks
leogr and others added 2 commits January 17, 2025 13:15
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the update/append_output_suggested_output branch from 90a2a1d to 85b7dcb Compare January 17, 2025 12:16
@leogr leogr requested a review from Issif January 17, 2025 12:16
@poiana poiana added the lgtm label Jan 17, 2025
@poiana
Copy link

poiana commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr added this to the falco-0.40.0 milestone Jan 22, 2025
@leogr
Copy link
Member Author

leogr commented Jan 28, 2025

/unhold

@poiana poiana merged commit 89bb1a3 into master Jan 28, 2025
6 checks passed
@poiana poiana deleted the update/append_output_suggested_output branch January 28, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Falco 0.40.0 changes
4 participants