Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CentOS 4.18+ Kernels to use GCC 9 #276

Merged
merged 1 commit into from
May 25, 2023

Conversation

EXONER4TED
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area cmd

/area pkg

/area docs

/area tests

What this PR does / why we need it:

We have a lot of failures for CentOS 4.18.x kernels. It seems that the image selector defaults them to GCC 8. I bumped them up to the GCC 9 image, and now it works locally. For example:

_output/bin/driverkit docker --output-module _output/scwx_centos_4.18.0-490.el8.x86_64_1.ko --kernelrelease 4.18.0-490.el8.x86_64 --kernelversion 1 --driverversion 4.0.0+driver --target centos --moduledevicename scwx-falco --moduledrivername scwx-falco --kernelurls http://mirror.centos.org/centos/8-stream/BaseOS/x86_64/os/Packages/kernel-devel-4.18.0-490.el8.x86_64.rpm --builderimage docker.io/falcosecurity/driverkit-builder:any-x86_64_gcc10.0.0_gcc9.0.0-246e90f

^ works now :)

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for your reviewer:

I only adjusted this in the CentOS builder, unsure this is universally true for all 4.18.x kernels. Also the change may be working because using GCC 9 bumps the builder image up to the GCC 9 image, which is based on bullseye rather than buster. Buster's build image has older versions of cpio/rpm2cpio, which had lower limits on how big rpms could be to unpack. Bullseye's version of these packages for managing rpms allows for bigger rpm file sizes.

Either way, the builds work now haha.

Does this PR introduce a user-facing change?:

Not really.

NONE

Signed-off-by: Logan Bond <lbond@secureworks.com>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes area/build Further information is requested labels May 25, 2023
@poiana poiana requested review from FedeDP and Lowaiz May 25, 2023 16:37
@poiana
Copy link

poiana commented May 25, 2023

LGTM label has been added.

Git tree hash: dfd645da283a6cdf38472accbe5680c173d28236

@poiana
Copy link

poiana commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwindsor, EXONER4TED

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [EXONER4TED,dwindsor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2debab8 into falcosecurity:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build Further information is requested dco-signoff: yes kind/bug Something isn't working lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants