Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(integrations/logdna): update grpc output socket name #11

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jgornowich
Copy link

The default grpc unix socket path was changed in 0.33.0 from /var/run/falco.sock to /run/falco/falco.sock and there were still some stale references to the old socket name.

@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

Welcome @jgornowich! It looks like this is your first PR to falcosecurity/contrib 🎉

@poiana poiana added the size/XS label Jan 22, 2024
Signed-off-by: John Gornowich <john.gornowich@progeny.net>
@jgornowich jgornowich force-pushed the grpc-socket-name-update branch from aba58ae to 0576b60 Compare January 22, 2024 16:48
@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgornowich, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

LGTM label has been added.

Git tree hash: bf455504e983095d3dbbc0790e8bece1d1462cf3

@poiana poiana merged commit c9c8ae6 into falcosecurity:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants