Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system): semver parts should not be limited to 0-9 #3349

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

matthewmayer
Copy link
Contributor

Semver components shouldnt be limited to one digit

Assuming all semvers are in the form x.y.z with single digits is likely to cause bugs with sorting etc

This PR allows y and z to go up to 20 for more variety, while keeping the numbers realistic

@matthewmayer matthewmayer requested a review from a team as a code owner December 28, 2024 18:56
@matthewmayer matthewmayer self-assigned this Dec 28, 2024
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f0a42b1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/677049e225a1190008b978fc
😎 Deploy Preview https://deploy-preview-3349.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer added p: 1-normal Nothing urgent m: system Something is referring to the system module c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e6d27a3) to head (f0a42b1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3349      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      217017   217017              
  Branches      941      941              
==========================================
- Hits       216966   216964       -2     
- Misses         51       53       +2     
Files with missing lines Coverage Δ
src/modules/system/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO versions numbers are a perfect use case for numbers with exponentially decreasing probability for higher version numbers.

@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
@ST-DDT ST-DDT requested review from a team December 28, 2024 19:00
@ST-DDT ST-DDT added this pull request to the merge queue Dec 29, 2024
Merged via the queue into faker-js:next with commit c0d92b8 Dec 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: system Something is referring to the system module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants