Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(typescript): add note for reuse of ConfidentialClient. #146

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

dgawande12
Copy link
Contributor

@dgawande12 dgawande12 commented Aug 25, 2022

Description

Added a comment just above the instantiation of the ConfidentialClient,
and under the Authentication section as well, mentioning that the instance can be reused.

Links

ENSC-574

Testing

Checklist

Ensure the following things have been met before requesting a review:

  • Follows all project developer guide and coding standards.
  • Tests have been written for the change, when applicable.
  • Confidential information (credentials, auth tokens, etc...) is not included.

@dgawande12 dgawande12 added the documentation Improvements or additions to documentation label Aug 25, 2022
@dgawande12 dgawande12 requested a review from a team as a code owner August 25, 2022 10:27
@dgawande12 dgawande12 self-assigned this Aug 25, 2022
@dgawande12 dgawande12 changed the title docs(typescript): add note about reuse of ConfidentialClient. docs(typescript): add note for reuse of ConfidentialClient. Aug 25, 2022
@dgawande12 dgawande12 force-pushed the docs/typescript/readme branch 3 times, most recently from 898a335 to 653b1ec Compare August 30, 2022 15:55
@dgawande12 dgawande12 force-pushed the docs/typescript/readme branch from 653b1ec to 6734c11 Compare August 30, 2022 15:55
@dgawande12 dgawande12 dismissed eschmidtfds’s stale review August 30, 2022 15:56

added in the changes.

@mima0815 mima0815 self-requested a review August 30, 2022 16:07
@dgawande12 dgawande12 merged commit 8421826 into main Aug 30, 2022
@dgawande12 dgawande12 deleted the docs/typescript/readme branch August 30, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants