-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visualizer interface #1062
visualizer interface #1062
Conversation
This is not fully ready it but more of a v0 scaffold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module needs to broken down into smaller, relevant plotters
Added different visualizer classes based on all the plots in demo.R. This is a good start and we can add more plot implementations as we encounter them. Here's a sample oh how you would call a particular plot with the above interfaces To call a specific plot like plot_allocator, you would use the RobynVisualizer class.
The fig variable now contains the matplotlib Figure object, which you can display or save as needed. |
remove the need for bool
the BaseVisualizer would look something like
|
Update:
|
Project Robyn
This PR adds a new visualization module to the Python port of Robyn. The change introduces a
RobynVisualizer
class with methods that correspond to the various plotting functions used in the R version of Robyn. This new module will enable the Python version to generate similar visualizations as the R version, enhancing the functionality and user experience of the Python port.Fixes #[Issue number for Python port visualization]
Type of change
How Has This Been Tested?
RobynVisualizer
class has been added with method declarations that mirror the R version's plotting functions.Note: This PR only includes the structure for the visualization module. Actual implementation of the plotting functions will be needed in subsequent PRs. Documentation updates will also be required once the implementation is complete.