Fix function declaration in if statement #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
👍 |
Firefox doesn't like these and throws.
|
@spicyj updated the pull request. |
| @@ -130,7 +130,7 @@ function print(outerComponent) { | |||
| debugger; | |||
There was a problem hiding this comment.
Yes, this is only used interactively and that's an error case.
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Firefox doesn't like these and throws. (cherry picked from commit 3c3c30a)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
Firefox doesn't like these and throws. (cherry picked from commit 3c3c30a)
| @@ -112,7 +112,7 @@ function print(outerComponent) { | |||
| var values = keys.map((childKey) => renderedChildren[childKey]); | |||
|
|
|||
| if (keys.length) { | |||
| function dump(children) { | |||
| var dump = function(children) { | |||
There was a problem hiding this comment.
it's better to write var dump = function dump(children) { to keep function names in stack trace
There was a problem hiding this comment.
The code have here is fine for what I use it for.
facebook-github-bot
added
the
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox doesn't like these and throws.
cc @zpao (for lint), @jimfb (for sync)