Setup grunt flow task and run on travis #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| var done = this.async(); | ||
| grunt.util.spawn({ | ||
| cmd: 'node_modules/.bin/flow' + extension, | ||
| args: ['check', '.'], |
There was a problem hiding this comment.
Will people run this interactively and get confused that it's slow?
There was a problem hiding this comment.
All of our grunt tasks are slow so probably doesn't matter.
|
Seems good. Grunt is weird. |
|
Ok. If you rebase, it should pass. |
|
@zpao updated the pull request. |
|
Alright, locked in at Flow 0.24.0 since that's what we have installed (and our flowconfig expects that). I also ensured we're using latest fbjs which comes with a |
|
@zpao updated the pull request. |
zpao
added a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
(cherry picked from commit c9504d9)
zpao
added a commit
that referenced
this pull request
Jun 14, 2016
(cherry picked from commit c9504d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6682, currently looking at the root for .flowconfig but can be changed as needed. cc @sebmarkbage