Fix the warning condition in ReactDebugTool and ReactDOMDebugTool #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current warning condition caused the first error to be swallowed, and all the next errors to be logged. I believe the intention was the opposite: to log the first error, and to ignore any next errors for the same method.
|
@gaearon updated the pull request. |
|
👍 |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Fix the warning condition in ReactDebugTool and ReactDOMDebugTool (cherry picked from commit 7dbc95f)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
Fix the warning condition in ReactDebugTool and ReactDOMDebugTool (cherry picked from commit 7dbc95f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current warning condition caused the first error to be swallowed, and all the next errors to be logged. I believe the intention was the opposite: to log the first error, and to ignore any next errors for the same method. I added some tests to verify the new behavior is correct.
Reviewers: @jimfb