Don't wrap drag events in IE/Edge in dev builds #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev builds wrap synthetic events inside other events for a better debug experience. However IE/Edge won't allow access to the DataTransfer.dropEffect property if it's wrapped in this way. The first time a drag event is fired, test if we're in an environment that behaves this way and disable React's improved development experience if we are.
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
Don't wrap drag events in IE/Edge in dev builds (cherry picked from commit 2e8f28c)
|
I'm going to revert this in #6741 – sorry I'm just seeing this now. ReactErrorUtils is a generic util and shouldn't know about SyntheticDragEvent, a DOM-specific concept. We should find a different fix for this. |
|
@spicyj Fair enough. How generic does ReactErrorUtils have to be? For instance, if SyntheticDragEvent had a flag on it along the lines of |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Don't wrap drag events in IE/Edge in dev builds (cherry picked from commit 2e8f28c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5700
Dev builds wrap synthetic events inside other events for a better debug experience. However IE/Edge won't allow access to the DataTransfer.dropEffect property if it's wrapped in this way.
DataTransfer objects can't be constructed by JavaScript, you can only use ones that the browser hands to you. So the first time a drag event is fired, we test if we're in an environment that behaves this way and disable React's improved development experience if we are.