-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with SyntheticEvents and Proxies #6189
Conversation
Not quite, I missed another piece of this... |
I suppose the subclasses should use Object.assign to inherit the static properties like they would on a native class. |
The subclasses don't seem to be the problem though, it's the base class. |
I think this might be setting up the wrong prototype:
Is that right? I think the second argument there should be extending the prototype of SyntheticEvent which has the right |
Or maybe not. That whole thing is so confusing. Create an issue to rewrite it and drop all the pooling shit? |
e8cc613
to
f707ee5
Compare
Object.create to the rescue. I think it should be safe to use blindly there since we're already guarded to engines that support Proxies. |
@zpao updated the pull request. |
Fix issue with SyntheticEvents and Proxies
Sorry, It's my fault. This warning is also possible to detect adding properties in destructor instead of using Proxies.
I agree. |
Fixes #6187 (hacky but it seems to work)