Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fixture dependency versions #20397

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Bump fixture dependency versions #20397

merged 6 commits into from
Dec 8, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 7, 2020

Upgrades webpack and friends.

I couldn't figure out how to keep it running in ESM mode. There's a Babel helper getting inserted into handler.server.js as soon as we have a dynamic import in there. So I switch to CJS mode in the second commit until we know what this is.

@gaearon gaearon requested a review from sebmarkbage December 7, 2020 20:29
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 7, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 315a218:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Dec 7, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 315a218

@sizebot
Copy link

sizebot commented Dec 7, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 315a218

@gaearon gaearon merged commit 0512cd6 into facebook:master Dec 8, 2020
@gaearon gaearon deleted the upgrade branch December 8, 2020 01:23
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* Bump all versions

* Switch to CJS mode

* Revert "Switch to CJS mode"

This reverts commit b3c4fd9.

* Fix ES mode

* Add nodemon to restart the server on edits

* Ignore /server/ from compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants