Only measure "base" times within ProfileMode #12821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
profile-mode-part-1
branch
from
34ac646 to
25c1d6a
Compare
bvaughn
changed the title
bvaughn
changed the title
bvaughn
changed the title
bvaughn
force-pushed
the
profile-mode-part-1
branch
from
25c1d6a to
27706f7
Compare
sebmarkbage
reviewed
May 15, 2018
| @@ -396,7 +396,9 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>( | |||
| nextChildren = null; | |||
|
|
|||
| if (enableProfilerTimer) { | |||
| stopBaseRenderTimerIfRunning(); | |||
| if (workInProgress.mode & ProfileMode) { | |||
There was a problem hiding this comment.
Why do you need to conditionally stop it? Stopping something already stopped is as cheap as checking the flag, probably cheaper, right?
There was a problem hiding this comment.
Totally. This is why I had the question in the PR description:
Should I remove the conditionals around stopBaseRenderTimerIfRunning? (Is it worth having them?)
I was on the fence.
There was a problem hiding this comment.
I'll just back out 27706f7 😄
…also" This reverts commit 27706f7.
sebmarkbage
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for this comment on PR #12745. Previously I was tracking base time for all fibers, regardless of whether they were inside of a
Profiler, because the place where I started the timer didn't yet know if it was in aProfileMode.I could move where I start/stop the timer somewhere else- where it would know- but this approach seemed simpler. It has a small potential downside of not measuring "base" time for the
Profilercomponent itself- but I think this is okay because (1) that time should be minimal and (2) it isn't really actionable for a developer.Questions
Should I remove the conditionals aroundstopBaseRenderTimerIfRunning? (Is it worth having them?)Caveats
ProfileModetree. This only updates a single numeric value though; it doesn't modify any attributes on a fiber.