Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type for ReactNative.NativeComponent #12805

Merged
merged 1 commit into from
May 14, 2018
Merged

Fix Type for ReactNative.NativeComponent #12805

merged 1 commit into from
May 14, 2018

Conversation

yungsters
Copy link
Contributor

Fixes the Flow type for ReactNative.NativeComponent.

This makes it so that View, Text, and a few other components are properly typed.

@yungsters yungsters requested review from sophiebits and bvaughn May 14, 2018 22:50
sophiebits
sophiebits approved these changes May 14, 2018
View reviewed changes
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itrustyou

@sebmarkbage
Copy link
Collaborator

idonttrustyou

@yungsters
Copy link
Contributor Author

I actually already landed this in facebook/react-native@de11ba2.

@yungsters yungsters merged commit b2d1604 into facebook:master May 14, 2018
@yungsters yungsters deleted the rn-types branch May 14, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiebits sophiebits sophiebits approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yungsters @sebmarkbage @sophiebits @facebook-github-bot