Rename Scheduler methods more accurately #12770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: In my mind the "callback" is the type signature but it doesn't say anything about the nature of the callback. It's like saying |
**what is the change?:** ``` rIC -> scheduleCallback ``` We will later expose a second method for different priority level, name TBD. Since we only have one priority right now we can delay the bikeshedding about the priority names. cIC -> cancelScheduledCallback This method can be used to cancel callbacks scheduled at any priority level, and will remain named this way. why make this change?: Originally this module contained a polyfill for requestIdleCallback and cancelIdleCallback but we are changing the behavior so it's no longer just a polyfill. The new names are more semantic and distinguish this from the original polyfill functionality. **test plan:** Ran the tests **why make this change?:** Getting this out of the way so things are more clear. **Coming Up Next:** - Switching from a Map of ids and an array to a linked list for storing callbacks. - Error handling
flarnie
force-pushed
the
improveSchedulerMethodNames
branch
from
719d3b2 to
c294700
Compare
flarnie
commented
May 15, 2018
| @@ -1,4 +1,4 @@ | |||
| /** | |||
| ** | |||
|
This should be an easy review~ |
gaearon
approved these changes
May 16, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We will later expose a second method for different priority level, name
TBD. Since we only have one priority right now we can delay the
bikeshedding about the priority names.
This method can be used to cancel callbacks scheduled at any priority
level, and will remain named this way.
why make this change?:
Originally this module contained a polyfill for requestIdleCallback
and cancelIdleCallback but we are changing the behavior so it's no
longer just a polyfill. The new names are more semantic and distinguish
this from the original polyfill functionality.
test plan:
Ran the tests
why make this change?:
Getting this out of the way so things are more clear.
Coming Up Next:
callbacks.