Unify context stack implementations #12359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
unifycontextstacks
branch
from
7939451 to
7bdd390
Compare
Implements the new context API on top of the existing ReactStack that we already use for host context and legacy context. Now there is a single array that we push and pop from. This makes the interrupt path slightly slower, since when we reset the unit of work pointer, we have to iterate over the stack (like before) *and* switch on the type of work (not like before). On the other hand, this unifies all of the unwinding behavior in the UnwindWork module.
acdlite
force-pushed
the
unifycontextstacks
branch
from
7bdd390 to
3bb28ba
Compare
acdlite
commented
Mar 13, 2018
| findCurrentUnmaskedContext(fiber: Fiber): Object, | ||
| }; | ||
|
|
||
| export default function(stack: Stack): LegacyContext { |
There was a problem hiding this comment.
There's a lot of noise in this diff, but all I did here was move this into a module constructor and add a corresponding Flow type.
bvaughn
approved these changes
Mar 13, 2018
| while (interruptedWork !== null) { | ||
| unwindInterruptedWork(interruptedWork); | ||
| interruptedWork = interruptedWork.return; | ||
| } |
There was a problem hiding this comment.
Should we (DEV-only) assert that the stack is empty after unwinding?
Details of bundled changes.Comparing: ad9544f...3ae3d45 create-subscription
Generated by 🚫 dangerJS |
LeonYuAng3NT
pushed a commit
to LeonYuAng3NT/react
that referenced
this pull request
Mar 22, 2018
* Use module pattern so context stack is isolated per renderer * Unify context implementations Implements the new context API on top of the existing ReactStack that we already use for host context and legacy context. Now there is a single array that we push and pop from. This makes the interrupt path slightly slower, since when we reset the unit of work pointer, we have to iterate over the stack (like before) *and* switch on the type of work (not like before). On the other hand, this unifies all of the unwinding behavior in the UnwindWork module. * Add DEV only warning if stack is not reset properly
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
* Use module pattern so context stack is isolated per renderer * Unify context implementations Implements the new context API on top of the existing ReactStack that we already use for host context and legacy context. Now there is a single array that we push and pop from. This makes the interrupt path slightly slower, since when we reset the unit of work pointer, we have to iterate over the stack (like before) *and* switch on the type of work (not like before). On the other hand, this unifies all of the unwinding behavior in the UnwindWork module. * Add DEV only warning if stack is not reset properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new context API on top of the existing ReactStack that we already use for host context and legacy context. Now there is a single array that we push and pop from.
This makes the interrupt path slightly slower, since when we reset the unit of work pointer, we have to iterate over the stack (like before) and switch on the type of work (not like before). On the other hand, this unifies all of the unwinding behavior in the UnwindWork module.
Also changes the context modules to use module constructors, so that each renderer gets a separate instance, which is currently broken when using react-reconciler.
This is not a total unification of legacy context and the new context API. A further step would be to implement the legacy,
contextTypes-based API on top ofReact.createContext.