[Android] Check that WS connection is open before closing it on failed. Fixes #3346

[yzarubin]

Check that the WS state is set to OPEN before trying to close it when the websocketFailed event fires. Otherwise the app throws an error at the Android level.

Fixes #3346

[satya164]

@mkonicek Can we merge this? Sorry for the issue, I didn't test properly after the review.

[mkonicek]

@facebook-github-bot shipit

Thanks for the fix @yzarubin!

[ide]

Should this check go in _closeWebSocket? Opened #3364 so we look into this later after cutting 0.13 with the fix in this PR.

[yzarubin]

@satya164 Thanks for the Android WS implementation!
@mkonicek Np! For some reason the FB bot never added the GH Review label to this PR, will the shipit still work?
@ide I considered adding the check to _closeWebSocket, but decided against it for now and just fixed the bug instead. We should probably first figure out which layer should ultimately own the WS state and be responsible for throwing errors.

[mkonicek]

@ide, @yzarubin It might be easier to maintain the state in native but don't think iOS does that so we're good for now. It would be amazing if someone could add a cross-platform example to the iOS and Android UI Explorer so we can at least play with the implementation and see it works :)

I'll request rigorous test plans and examples on complex PRs in the future.

[mkonicek]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1654193344827885/int_phab to review.