Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Wear service to lower ram usage. #3

Merged
merged 3 commits into from
May 16, 2022

Conversation

mikhoul
Copy link

@mikhoul mikhoul commented Jun 19, 2019

I removed Wear service to lower the memory usage since Wear adoption seem to be pretty low.

https://mashable.com/article/android-wear-is-not-dead/

mikhoul added 3 commits June 17, 2019 16:31
Unlock "Now Playing" themes that were locked.
Disable Wear service to minimize ram use.
Disable Donate Activity and I will remove the unused cote later and remove the "donate panel option" in the setting too.
@fabmazz
Copy link
Owner

fabmazz commented Jun 23, 2019

Hello @mikhoul and thank you for the work you did on analyzing the performance of the app.
Disabling wear service should lower RAM usage, though I still don't know if the wear service needs google stuff to work. In any case, some people might need it, and it wouldn't be a good thing to disable it permanently from the code base.
As the issue page goes, I have no idea at the moment how to add that, I fear that, since this repo is a fork, github wouldn't let you have it. About this, the code should really be moved to a separate repo with a different name, and also the title of the app should be changed.
I am not a developer, I simply downloaded the source code of the Timber app when it disappeared from F-Droid, then built it by myself and later I wanted to put it back to F-Droid.

@mikhoul
Copy link
Author

mikhoul commented Jun 23, 2019

I'm not a Java developer too but I will do my best to clean up the code in my part time.

The wear adoption is very low from what I've read so sure maybe few users use it but IMO lowering the memory usage is better since it prevent the app from being discarded when the screen-lock is on.

Also the wear service need Google Play services to sync...

image

To enable the Issue: Go to the main page of the Repo and click on Settings:

image

Scroll down till you see the "Features" section and tick the box beside "Issues"
image

Changing the name of the repo is easy :
image

So maybe you could just add the PR I've done that you feel comfortable with it this way the other users could profit of them too 😄

Wishing you a great week-end ! :octocat:

@fabmazz
Copy link
Owner

fabmazz commented Jun 23, 2019

Thank you for your instructions, I have now enabled the issues.

I failed to mention before that this app is not developed anymore, as the original author created a new version in Kotlin. I appreciate your enthusiasm in the analysis of the code, and instead of spending time on this app, it would be much better to create a FOSS version of the new one (which is called TimberX).

I'll still accept gladly the results of your work on the maintenance of this app.

If you can tell me that the code from this PR builds and the app runs with no problems, I'll accept this pull request.

@mikhoul
Copy link
Author

mikhoul commented Jun 23, 2019

I've seen the new one but it will take years to have the same functions and the stability of the original Timber.

Sadly there is lot of bug and it crash a lot and the last release was in February... the dev mus be busy with his daytime job so I would not hold my breath.


No problem before sending you PR I will test them thoroughly. 😄

@fabmazz fabmazz merged commit 9d0d06e into fabmazz:f-droid May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants