Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish-list: override parameter to merge function #24

Closed
Loreton opened this issue Aug 31, 2020 · 3 comments
Closed

wish-list: override parameter to merge function #24

Loreton opened this issue Aug 31, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Loreton
Copy link

Loreton commented Aug 31, 2020

I just discovered your "benedict" package and I'm really enjoying it. It greatly simplifies the handling of dict in python. I am not a professional programmer but I love doing it. I wanted to ask if it is possible to add the "override" parameter to the merge() function, perhaps keeping its default value to False. In the meantime, waiting for your reply, I took the liberty of making a copy of merge.py and modifying it accordingly (attached is my solution just as sample).
Thanks very much for your work
Regards
Loreto

LnMerge.zip

@Loreton Loreton added the enhancement New feature or request label Aug 31, 2020
@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Aug 31, 2020

@Loreton I'm really glad you enjoy it, thank you!
You request seems reasonable and backward-compatible, I will add it to the next release!
PS. the right naming for this is overwrite not override.

@Loreton
Copy link
Author

Loreton commented Aug 31, 2020

Overwrite...right. Thank you Fabio.

@fabiocaccamo
Copy link
Owner

Option available in 0.18.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants