Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call vfoo_ from foo_ functions #88

Closed
eyalroz opened this issue Jan 22, 2022 · 0 comments
Closed

Call vfoo_ from foo_ functions #88

eyalroz opened this issue Jan 22, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 22, 2022

Instead of calling _vsnprintf() directly from each foo_() function, let's call vfoo_(). This will avoid a tiny bit of code duplication now; but soon will probably avoid a little more code duplication - due to a planned fix for #87 .
@eyalroz eyalroz added the task label Jan 22, 2022
@eyalroz eyalroz self-assigned this Jan 22, 2022
eyalroz added a commit that referenced this issue Jan 22, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
ebd4cdf 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Jan 22, 2022
eyalroz added a commit that referenced this issue Jan 26, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
c3107dd 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
8963b66 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
f38314c 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
eyalroz added a commit that referenced this issue Jan 31, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
f49bc25 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
eyalroz added a commit that referenced this issue Feb 11, 2022
@eyalroz
Fixes #88: All non-va-list XXXprintf_() functions now use their va-…
47e9801 
…list corresponding functions rather than directly calling `_vnsprintf()` - reducing some code duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-develop A changeset fixing this issue has been commiutted to the development branch task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz