Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-7069: Test EOF calls to p256verify #1021

Merged
merged 1 commit into from
Dec 16, 2024
Merged

new(tests): EOF - EIP-7069: Test EOF calls to p256verify #1021

merged 1 commit into from
Dec 16, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Dec 14, 2024

🗒️ Description

Since RIP-7212 has been in and out of Prague some clients have it activated when it should not be. Verify the precompile does nothing.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon
Test EOF calls to p256verify
42dfb7b 
Since RIP-7212 has been in and out of prague some clients have it
activated when it should not be. Verify the precompile does nothing.

Signed-off-by: Danno Ferrin <danno@numisight.com>
marioevz
marioevz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz changed the title Test EOF calls to p256verify new(tests): EOF - EIP-7069: Test EOF calls to p256verify Dec 16, 2024
@marioevz marioevz merged commit 1496c64 into ethereum:main Dec 16, 2024
3 checks passed
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@shemnon @codeofcarson
new(tests): EOF - EIP-7069: Test EOF calls to p256verify (ethereum#1021)
1f8b24f 
Since RIP-7212 has been in and out of prague some clients have it
activated when it should not be. Verify the precompile does nothing.

Signed-off-by: Danno Ferrin <danno@numisight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @marioevz