Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowctl --overwrite does not overwrite changed specs #1590

Closed
tmnd1991 opened this issue Aug 28, 2024 · 0 comments · Fixed by #1600
Closed

Flowctl --overwrite does not overwrite changed specs #1590

tmnd1991 opened this issue Aug 28, 2024 · 0 comments · Fixed by #1600
Assignees

Comments

@tmnd1991
Copy link

I found a bug where when I:

  1. pull specs (using flowctl catalog pull-specs --prefix "$source" --overwrite)
  2. change them through UI
  3. pull again (using flowctl catalog pull-specs --prefix "$source" --overwrite)

They don't change locally, if I rm them locally and then pull again, they are correct.

@jgraettinger jgraettinger self-assigned this Aug 30, 2024
jgraettinger added a commit that referenced this issue Aug 30, 2024
Use the _local_ scope, NOT the remote one, to determine the existing
local scope of a resource which is being kept or over-written.

We must also clear out imports of a local spec which is being replaced,
because the replacement is a fully inline model, and we're typically
going to indirect it before writing out resources, which would otherwise
result in duplicated imports.

Fixes #1590
Fixes #1558
jgraettinger added a commit that referenced this issue Sep 4, 2024
Use the _local_ scope, NOT the remote one, to determine the existing
local scope of a resource which is being kept or over-written.

We must also clear out imports of a local spec which is being replaced,
because the replacement is a fully inline model, and we're typically
going to indirect it before writing out resources, which would otherwise
result in duplicated imports.

Fixes #1590
Fixes #1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants