Attempt to fix the CI build #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotty
force-pushed
the
pr/fix-ci
branch
5 times, most recently
from
d808b49 to
d92eea6
Compare
Since our `dev-dependencies` now require a newer Rust version, no longer do a full test for Rust 1.32.0. It seems the `time` crate is especially aggressive in its MSRV bumping; the `dev-dependencies` should be investigated to see if they can be trimmed to lower the MSRV for running the test suite.
|
Seems appveyor is experiencing intermittent failures with the monitoring uint test; I've not looked in to the issue yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some new tricks clippy learned, and more importantly building is broken on 1.32 due to some
dev-dependenciesrequiring new language features. Sincedev-dependenciesshould not affect downstream compilation, we should probably not do a full build on 1.32 anymore, but instead just ensure that the code still compiles.