Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update steve when update cluster #3773

Merged
merged 2 commits into from
Jan 20, 2022
Merged

fix: update steve when update cluster #3773

merged 2 commits into from
Jan 20, 2022

Conversation

CraigMChen
Copy link
Contributor

What this PR does / why we need it:

fix: update steve when update cluster

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English fix: update steve when update cluster
🇨🇳 中文 更新集群后更新对应的steve

Need cherry-pick to release versions?

Need cherry-pick to release/1.6-alpha.2

@erda-bot erda-bot requested a review from luobily January 17, 2022 11:31
@codecov
Copy link

codecov bot commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #3773 (d6531c8) into master (87aba46) will increase coverage by 0.02%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3773      +/-   ##
==========================================
+ Coverage   18.48%   18.51%   +0.02%     
==========================================
  Files        1455     1455              
  Lines      152873   152959      +86     
==========================================
+ Hits        28264    28317      +53     
- Misses     121717   121732      +15     
- Partials     2892     2910      +18
Impacted Files Coverage Δ
modules/cmp/steve/aggregator.go 0.00% <0.00%> (ø)
...nts/cmp-dashboard-events-list/eventTable/render.go 55.88% <93.75%> (ø)
...ator/services/deployment_order/deployment_order.go 5.76% <0.00%> (-0.49%) ⬇️
...t-protocol/components/project-runtime/list/list.go 32.83% <0.00%> (-0.16%) ⬇️
...rvices/deployment_order/deployment_order_cancel.go 0.00% <0.00%> (ø)
.../services/deployment_order/deployment_order_get.go 61.60% <0.00%> (+1.09%) ⬆️
...nts/project-runtime/advanceFilter/advanceFilter.go 17.03% <0.00%> (+2.40%) ⬆️
...rvices/deployment_order/deployment_order_create.go 44.62% <0.00%> (+3.84%) ⬆️
...services/deployment_order/deployment_order_list.go 80.55% <0.00%> (+6.87%) ⬆️

@luobily
Copy link
Member

luobily commented Jan 20, 2022

/approve

@erda-bot erda-bot merged commit b24c11a into erda-project:master Jan 20, 2022
@CraigMChen
Copy link
Contributor Author

/cherry-pick release/1.6-alpha.2

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Jan 20, 2022
@CraigMChen @erda-bot
fix: update steve when update cluster (erda-project#3773)
d5f27d8 
* fix: update steve server when update cluster; add logs

* unit test
@erda-bot erda-bot mentioned this pull request Jan 20, 2022
Merged
erda-bot added a commit that referenced this pull request Jan 20, 2022
@erda-bot @CraigMChen
fix: update steve when update cluster (#3773) (#3820)
e119076 
* fix: update steve server when update cluster; add logs

* unit test

Co-authored-by: CMC <49681321+CraigMChen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erda-bot erda-bot erda-bot approved these changes

@luobily luobily Awaiting requested review from luobily

Assignees
No one assigned
Labels
approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CraigMChen @luobily @erda-bot