-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send pop out pipeline id to etcd, and watch pop out in leader #2742
Merged
erda-bot
merged 1 commit into
erda-project:master
from
chengjoey:fix/pipeline-queue-cancel
Nov 2, 2021
Merged
send pop out pipeline id to etcd, and watch pop out in leader #2742
erda-bot
merged 1 commit into
erda-project:master
from
chengjoey:fix/pipeline-queue-cancel
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjoey
force-pushed
the
fix/pipeline-queue-cancel
branch
from
November 1, 2021 10:09
5502e72
to
1c9dbd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
+ Coverage 16.74% 16.88% +0.13%
==========================================
Files 1261 1266 +5
Lines 128238 128732 +494
==========================================
+ Hits 21477 21734 +257
- Misses 104555 104751 +196
- Partials 2206 2247 +41
|
chengjoey
force-pushed
the
fix/pipeline-queue-cancel
branch
from
November 1, 2021 11:11
1c9dbd8
to
27610ac
Compare
sfwn
approved these changes
Nov 2, 2021
/approve |
erda-bot
approved these changes
Nov 2, 2021
/cherry-pick release/1.4 |
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 2, 2021
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 2, 2021
erda-bot
added a commit
that referenced
this pull request
Nov 2, 2021
erda-bot
added a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
queue manager send pop out pipeline id to etcd, and watch pop out in leader
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.