Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update markdown editor interaction and style #853

Merged
merged 3 commits into from
Aug 5, 2021
Merged

feat: update markdown editor interaction and style #853

merged 3 commits into from
Aug 5, 2021

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Aug 5, 2021

What this PR does / why we need it:

  • disable show editor and preview at the same time
  • hide toolbar buttons when preview content
  • hide toggle toolbar arrow
  • always show bottom button group

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
2021-08-05 15 29 39

ChangeLog

Language Changelog
🇺🇸 English update markdown editor interaction and style
🇨🇳 中文 更新 markdown 编辑器交互和样式

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added the feature new feature label Aug 5, 2021
@daskyrk daskyrk marked this pull request as draft August 5, 2021 07:37
@daskyrk daskyrk marked this pull request as ready for review August 5, 2021 07:56
@McDaddy McDaddy merged commit 7568e33 into erda-project:master Aug 5, 2021
@daskyrk daskyrk deleted the feature/update-markdown-editor branch August 26, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McDaddy McDaddy McDaddy approved these changes

Assignees
No one assigned
Labels
feature new feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daskyrk @McDaddy