fix(rpc): fix return type of starknet_getClass and starknet_getClassAt
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Jun 24, 2022
No. |
kkovaacs
force-pushed
the
krisztian/fix-rpc-getclass-program
branch
from
e312062 to
067199b
Compare
…ssAt` According to the OpenRPC specification the Base64 encoded, gzip compressed JSON representation of the class should be returned. (The same representation that is used by the write API.) Just like the entry points, we don't store this in the database directly, so we have to decompress our full JSON, extract the relevant part, and then compress and encode it as expected by the specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OpenRPC specification the Base64 encoded, gzip
compressed JSON representation of the class should be returned. (The
same representation that is used by the write API.)
Just like the entry points, we don't store this in the database
directly, so we have to decompress our full JSON, extract the relevant
part, and then compress and encode it as expected by the specification.
Fixes #406