fix: hoist spans into spawn_blocking #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Jun 9, 2022
CHr15F0x
approved these changes
Jun 9, 2022
this will ensure the calling rpc_method=name span will exist in both the async and sync part, should there be need for it. checked that tokio doesn't at least yet provide any context hoisting like this, but it can wrap the blocking task in it's own span with the tracing feature.
koivunej
force-pushed
the
spans_everywhere
branch
from
da1ae41 to
adf809c
Compare
kkovaacs
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will ensure the calling rpc_method=name span will exist in both the async and sync part, should there be need for it. outer async part doesn't need this because it will be entered once more when the poll execution continues.
marking this as a fix even though we probably never witnessed any of these being missing..