fix: forward at tag calls #315
Conversation
|
Should we not explicitly be checking for |
| // only forward calls to specific blocks to our local impl, because we currently | ||
| // don't do an on-demand poll and flush for the pending block. | ||
| // | ||
| // unsure about the expected Tag::Latest semantics either. |
There was a problem hiding this comment.
Shouldn't we be checking if we're at head and forward for latest only if not at head?
There was a problem hiding this comment.
Should we not explicitly be checking for
pendingand only forward those to the sequencer? Andlatestright now is the highest L2 block number we have.
Iuuc, latest in the api spec refers to global L2 network latest and not our node-local L2 head? Or am I misunderstanding what latest means?
There was a problem hiding this comment.
Yeah that's one possible implementation. I wouldn't do it here though. Didn't see your second comment but this just highlights the unsureness I'm referring to in the comment.
There was a problem hiding this comment.
Since there is never a global latest I would expect latest to be local. Currently there is a single global latest, but thats because the sequencer is not yet decentralized.
There was a problem hiding this comment.
Would be nice to clarify this with Starkware, to be sure if we should aim for the correct meaning right from the start. Right being what you @Mirko-von-Leipzig mentioned (no single global latest after sequencers decentralizing).
There was a problem hiding this comment.
I think regardless that's outside of scope of this PR, which is a correctness fix needed either way. Discussions on forwarding what and what not are already scheduled.
forward them to sequencer because we can't support the two at the moment, or at least the latest semantics would probably be different from what py/src/call.py supports (queries highest l2 block number).
koivunej
force-pushed
the
forward_non_tag_calls
branch
from
f536d97 to
2bf8c61
Compare
forward them to sequencer because we can't support the two at the
moment, or at least the latest semantics would probably be different
from what py/src/call.py supports (queries highest l2 block number).