-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable functionality to use common schema in model database #30
Enable functionality to use common schema in model database #30
Conversation
@jodybuz , Thank You for the PR. I will review/test and get back.
|
Thanks @entechlog - I have made some updates to the README this morning. Hopefully it makes things easier to understand. I've also removed the formatting in the "integration_tests/dbt_project.yml" file. (Sorry - these were added by my linter - so not necessary.) But I've kept in my new parameter to enable future testing - hope thats ok? |
Thank You @jodybuz , I will test this and get it merged |
Hi @entechlog - Sorry, but I've added one last change into this PR (hope it's not too late.) We have custom materializations in our dbt project, so I've added a parameter which allows your package to apply masking policies to these types of models. I've updated the README with instructions on how to use this feature too. |
@jodybuz , Sure. Sorry I have been busy for last couple of days. I will try to take a look at them today evening |
@jodybuz , The tests ran fine, so going a head and merging this now. |
Thanks @entechlog and @nadesansiva - this is going to be so useful for us (and hopefully others too.) |
A new variable has been added use_common_masking_policy_schema_only which allows for a common schema within the model database to be specified for storing masking policies.
(Similar to existing functionality which uses use_common_masking_policy_db to set a common database and schema to store masking policies.)