Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entgql: extend docs for Bind and Unbind annotation options #310

Merged
merged 1 commit into from
May 8, 2022

Conversation

dorlib
Copy link
Contributor

@dorlib dorlib commented May 7, 2022

No description provided.

entgql/annotation.go Outdated Show resolved Hide resolved
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dorlib

I'll suggest a change to the Bind doc later.

entgql/annotation.go Outdated Show resolved Hide resolved
// You can safely remove this function from your scheme.
//
// Deprecated: the Bind option predates the Unbind option, and it is planned
// the Bind option predates the Unbind option, and it is planned
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// the Bind option predates the Unbind option, and it is planned
// Deprecated: The Bind option predates the Unbind option, and it is planned

@dorlib dorlib force-pushed the bind-extand-docs branch from e98ea82 to 8a8a9b8 Compare May 8, 2022 19:21
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @dorlib

Thanks 🙏

@a8m a8m merged commit 08d1e98 into ent:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants