-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entgql(WhereInput): remove graphql-go/graphql #267
Conversation
54b28d9
to
77a675f
Compare
BC: always overwritten In the previous version, the EntGQL extension will check if the input data type exists in the |
@giautm do you think it would be possible to add support for some kind of "hook" on the whereFilters part? Maybe allowing us (users) to provide a custom Right now, even if we change the templates for the where filters, there is no way to change the |
Hey @crossworth, thank you for your kind words. I plan to add some hooks for modifying the schema after we generate it from the graph. But, currently, the WhereInput and GQL Schema aren't connected yet to become a single schema. I will continue on it after this PR get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, just a few comments before accepting.
Great work @giautm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯
We replace graphql-go/graphql with vektah/gqlparser
77a675f
to
db170e7
Compare
Thanks for landing this @giautm. For next time, please use Also, your PRs were merged to |
We replace graphql-go/graphql with vektah/gqlparser
This commit includes small break changes, that is will notupdate the existed input in the schema.
You HAVE TO remove the duplicated input from your schema.
Refactor WhereInput feature for ent/ent#2351