Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entgql: added new annotations #251

Merged
merged 6 commits into from
Mar 7, 2022
Merged

entgql: added new annotations #251

merged 6 commits into from
Mar 7, 2022

Conversation

giautm
Copy link
Collaborator

@giautm giautm commented Mar 6, 2022 •
edited
Loading

Related: ent/ent#2351

@giautm giautm requested a review from a8m March 6, 2022 22:05
giautm
giautm commented Mar 6, 2022
View reviewed changes
entgql/schema_test.go Outdated Show resolved Hide resolved
@giautm giautm force-pushed the entgql-annotations branch from 1f26c8c to 21b5be4 Compare March 7, 2022 03:45
@giautm giautm force-pushed the entgql-annotations branch from 5822b1d to 0977a54 Compare March 7, 2022 08:22
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/directive.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/directive.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/directive.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/directive.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/annotation.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/schema.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/schema.go Outdated Show resolved Hide resolved
@giautm giautm force-pushed the entgql-annotations branch from ac30d48 to 826d3fd Compare March 7, 2022 21:04
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/schema.go Show resolved Hide resolved
@giautm giautm force-pushed the entgql-annotations branch from 826d3fd to a205a27 Compare March 7, 2022 21:11
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/annotation.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 7, 2022
View reviewed changes
entgql/internal/todoplugin/ent/schema/category.go
Comment on lines +89 to +90
entgql.RelayConnection(),
entgql.Implements("Entity"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty.

a8m
a8m approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@giautm @a8m
Update entgql/annotation.go
0946f69 
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
@a8m a8m merged commit 5a4e0c9 into master Mar 7, 2022
@a8m a8m deleted the entgql-annotations branch March 7, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giautm @a8m