entgql: create plugin for gqlgen [Stage1] #241
Conversation
giautm
force-pushed
the
gqlgen-relay-plugin
branch
3 times, most recently
from
da4957b to
a772776
Compare
giautm
force-pushed
the
gqlgen-relay-plugin
branch
from
0948072 to
add22b7
Compare
giautm
force-pushed
the
gqlgen-relay-plugin
branch
from
2ef09aa to
3b980d2
Compare
giautm
force-pushed
the
gqlgen-relay-plugin
branch
from
3b980d2 to
ce3256a
Compare
giautm
force-pushed
the
gqlgen-relay-plugin
branch
from
f73d0e9 to
28e280b
Compare
entgql/internal/todoplugin/ent/schema/durationgql/durationgql.go
Outdated
Show resolved
Hide resolved
giautm
changed the title
| ) | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err.Error()) | ||
| os.Exit(3) |
There was a problem hiding this comment.
Not sure, it's come from the original PR. I can fix it by update to Fatal().
entgql/internal/todoplugin/ent/schema/durationgql/durationgql.go
Outdated
Show resolved
Hide resolved
| @@ -188,6 +193,14 @@ func WithWhereFilters(b bool) ExtensionOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithSchemaGenerator add a hook for generate GQL schema | |||
| func WithSchemaGenerator() ExtensionOption { | |||
There was a problem hiding this comment.
💯
That means users can use it even if they don't use gqlgen.
There was a problem hiding this comment.
Yes, but it require some refactor for WhereInput feature to working as the same way
| } | ||
| } | ||
|
|
||
| type gqlgenPlugin struct { |
There was a problem hiding this comment.
Nice, but it's actually more complex than setting autobind or the @goModel directive in the generated schema.
There was a problem hiding this comment.
autobind didnt work in all cases. So, the user still need to manual config mapping. Then, we have to read config.yaml to recogine them.
If we can detect and mapping it correctly, we not need to read config.yaml anymore and not must to depends on gqlgen.
|
@cliedeman, I added you as a co-author of this PR. Thank you both for your contribution ❤️ 🙏
|
Related: ent/ent#2351