Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating JSON fields #227

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

anivanovic
Copy link
Contributor

Easiest implementation to support generating JSON fields I could think of.
Developers still need to change schema but at least generation does not fail
and generated file compiles.

@zeevmoney
Copy link
Contributor

@anivanovic I made a similar contribution, I addressed more cases with JSON field, would you like to talk in Discord in order to push it together?

@anivanovic
Copy link
Contributor Author

@anivanovic I made a similar contribution, I addressed more cases with JSON field, would you like to talk in Discord in order to push it together?

Sure! Can you give me Discord link? I am also in Slack #ent channel. So we can open a thread there also.

@a8m
Copy link
Member

a8m commented Feb 13, 2022

Thanks for the support @zeevmoney, and thanks @anivanovic for the contribution.
Here's a link to the Discord server. Feel free to create a thread there - https://discord.gg/qZmPgTE6RX

I also suggest you use go/parser.ParseExpr to construct and validate the expression for configuring the JSON type. Please, feel free to mention me in Discord 😃

Copy link
Contributor

@zeevmoney zeevmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@a8m a8m merged commit 4b15fea into ent:master Feb 14, 2022
@a8m
Copy link
Member

a8m commented Feb 14, 2022

Thanks, @anivanovic for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants