Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove package name for the error #205

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix: remove package name for the error #205

merged 2 commits into from
Jan 24, 2022

Conversation

giautm
Copy link
Collaborator

@giautm giautm commented Jan 15, 2022

Let it be consistent with other error

@giautm
Copy link
Collaborator Author

giautm commented Jan 15, 2022 •
edited
Loading

I really don't want to expose the package name to users like:

entgo.io/contrib/entgql/internal/todouuid/ent: empty predicate CategoryWhereInput

Other errors from EntGQL also don't have the prefix:
Screen Shot 2022-01-15 at 08 28 55

@a8m a8m merged commit 9763c9a into ent:master Jan 24, 2022
@giautm giautm deleted the patch-1 branch January 24, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giautm @a8m