Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entoas: pagination params to Int instead of Int32 #196

Merged
merged 1 commit into from
Jan 4, 2022
Merged

entoas: pagination params to Int instead of Int32 #196

merged 1 commit into from
Jan 4, 2022

Conversation

masseelch
Copy link
Collaborator

@masseelch masseelch commented Jan 4, 2022 •
edited
Loading

ogen just recently added the Int() spec-builder which is mapped to the Go int type. This PR uses the new Int() builder to not have ogen generate int32 everywhere.

@masseelch masseelch requested review from a8m and rotemtam January 4, 2022 08:08
@masseelch masseelch merged commit 5255cb0 into master Jan 4, 2022
@masseelch masseelch deleted the feat/int-pagination-params branch January 4, 2022 12:57
@masseelch masseelch mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

@a8m a8m Awaiting requested review from a8m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masseelch @rotemtam